Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/devp2p: use AWS-SDK v2 #22360

Merged
merged 7 commits into from
Mar 19, 2021
Merged

cmd/devp2p: use AWS-SDK v2 #22360

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fa65908
update go mod version to match go build version
qhenkart Feb 20, 2021
eddd9f3
refactor to sdk v2
qhenkart Feb 21, 2021
4690361
aws-sdk-v2
qhenkart Feb 21, 2021
e03f7b6
simplify pagination logic
qhenkart Feb 21, 2021
d3b62d0
simplify wait logic
qhenkart Feb 21, 2021
ccf0a43
move retrylimit breaker into block for readability
qhenkart Feb 21, 2021
eace772
optimize DNS propogation by first making all changes and then waiting
qhenkart Feb 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
move retrylimit breaker into block for readability
  • Loading branch information
@qhenkart
qhenkart committed Feb 21, 2021
commit ccf0a43ea171b1fc6149683fe0b79012a871c945
7 changes: 4 additions & 3 deletions cmd/devp2p/dns_route53.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,17 +126,18 @@ func (c *route53Client) deploy(name string, t *dnsdisc.Tree) error {
log.Info(fmt.Sprintf("Waiting for change request %s", *resp.ChangeInfo.Id))
wreq := &route53.GetChangeInput{Id: resp.ChangeInfo.Id}
var count int
for count < maxRetryLimit {
for {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiters have been refactored in v2. They are no longer local extensions of the request.Waiter type. V2 does have support for waiters but limited to certain packages and functions.

Please see how the previous waiter was implemented
Like my implementation here, you can see that the waiter checks the status 60 times in 30 second increments

v2 waiter implementations are handled in a similar fashion

wresp, err := c.api.GetChange(context.TODO(), wreq)
if err != nil {
return err
}

if wresp.ChangeInfo.Status == types.ChangeStatusInsync {
count++

if wresp.ChangeInfo.Status == types.ChangeStatusInsync || count >= maxRetryLimit {
break
}

count++
time.Sleep(30 * time.Second)
}
}
Expand Down