EIP-1559 tx pool support #22898
Merged
EIP-1559 tx pool support #22898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsfelfoldi
requested review from
holiman,
karalabe and
rjl493456442
as code owners
zsfelfoldi
force-pushed
the
eip1559-mempool
branch
2 times, most recently
from
5cb5e6c
to
c604a47
Compare
holiman
reviewed
May 20, 2021
| @@ -279,15 +279,23 @@ func (l *txList) Add(tx *types.Transaction, priceBump uint64) (bool, *types.Tran | |||
| // If there's an older better transaction, abort | |||
| old := l.txs.Get(tx.Nonce()) | |||
| if old != nil { | |||
| // threshold = oldGP * (100 + priceBump) / 100 | |||
| if old.FeeCapCmp(tx) >= 0 || old.TipCmp(tx) >= 0 { | |||
There was a problem hiding this comment.
In this strategy, we can only replace the transaction with 10% feeCap bump and 10% tip bump. It might hurt the UX to some extent.
For example, if the user already specify a high enough feeCap but a barely enough tip. And he wants to speed up the inclusion, he has to bump the feeCap as well. If the basefee raises up, then the maximum possible payment is increased.
There was a problem hiding this comment.
This has been discussed at the 1559 dev channel, right now this replacement condition seems to be the best choice.
|
Rebased + fixed rebase problems |
|
|
zsfelfoldi
force-pushed
the
eip1559-mempool
branch
from
2b9701f
to
3df30d8
Compare
|
This is now running on |
* replace GasPriceCmp and GasPriceIntCmp with FeeCapCmp, FeeCapIntCmp, TipCmp, TipIntCmp (and update all usages) * update Cost to use FeeCap instead of GasPrice
* add eip1559 status indicator * add DynamicFeeTx to transaction type check * remove underpriced transactions on minimum miner tip increases * require both a fee cap and tip bump for transaction replacement * use tip as secondary comparison criterion for priceHeap sorting
…transaction validation
…e post-EIP-1559 arm of pool.SetMinMinerFee()
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jul 5, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jul 26, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Aug 1, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Aug 11, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Aug 12, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Aug 12, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Aug 12, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Aug 19, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Aug 21, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Aug 22, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Aug 23, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Aug 24, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Aug 25, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Aug 25, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Aug 26, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Aug 26, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Aug 26, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Sep 2, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Sep 6, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Sep 9, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Sep 9, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Sep 9, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Sep 12, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Sep 12, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Sep 19, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements EIP-1559 compatible transaction pool with dual heap eviction ordering.
It is based on #22791
The eviction ordering scheme and the reasoning behind it is described here: https://gist.github.com/zsfelfoldi/9607ad248707a925b701f49787904fd6