accounts/abi/bin/backends: return basefee in suggestGasPrice's #23838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjl493456442
approved these changes
Nov 1, 2021
MariusVanDerWijden
changed the title
holiman
approved these changes
Nov 1, 2021
MariusVanDerWijden
requested changes
Nov 1, 2021
| @@ -462,7 +462,7 @@ func (b *SimulatedBackend) PendingNonceAt(ctx context.Context, account common.Ad | |||
| // SuggestGasPrice implements ContractTransactor.SuggestGasPrice. Since the simulated | |||
| // chain doesn't have miners, we just return a gas price of 1 for any call. | |||
| func (b *SimulatedBackend) SuggestGasPrice(ctx context.Context) (*big.Int, error) { | |||
| return big.NewInt(1), nil | |||
There was a problem hiding this comment.
Header might not have a basefee (if the simulated backend was instantiated without the london block)
So the correct logic would be
if header.BaseFee != nil {
return header.Basefee
}
return big.NewInt(1)
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
sidhujag
pushed a commit
to syscoin/go-ethereum
that referenced
this pull request
Nov 1, 2021
…m#23838) Co-authored-by: mrx <mrx@mrx.com>
This was referenced Sep 23, 2022
yongjun925
pushed a commit
to DODOEX/go-ethereum
that referenced
this pull request
Dec 3, 2022
…m#23838) Co-authored-by: mrx <mrx@mrx.com>
19 tasks
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jul 26, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Aug 1, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Aug 11, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Aug 12, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Aug 12, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Aug 12, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Aug 12, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Aug 12, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Aug 19, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Aug 21, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Aug 22, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Aug 23, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Aug 24, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Aug 25, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Aug 25, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Aug 26, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Aug 26, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Aug 26, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Sep 2, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Sep 6, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Sep 9, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Sep 9, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Sep 9, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Sep 10, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Sep 12, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Sep 12, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Sep 19, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Sep 19, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Sep 19, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EIP-1559 changes the min amount of gas price we can execute a transaction with (current basefee).
The simulated backend always returned 1 on suggestGasPrice. With 1559 we need to return at least the basefee, otherwise transactions will never be mined.