Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signer, accounts: move eip-712 types to apitypes package. fixes #23972 #24029

Merged
merged 3 commits into from
Dec 5, 2021

Conversation

holiman
Copy link
Contributor

@holiman holiman commented Dec 1, 2021

Moves things around a bit, should fix #23972.
Other than moving things around (and a little bit of docs added), nothing should have changed.

@fjl
Copy link
Contributor

fjl commented Dec 2, 2021

I'm not sure about moving the content-type constants. The move adds multiple dependencies on signer/core/apitypes that weren't there before. I think we could leave these constants in package accounts for now.

@fjl fjl merged commit 619a3e7 into ethereum:master Dec 5, 2021
@fjl fjl added this to the 1.10.14 milestone Dec 5, 2021
ivanshukhov pushed a commit to Kapoio/go-kapoio that referenced this pull request Dec 11, 2021
JacekGlen pushed a commit to JacekGlen/go-ethereum that referenced this pull request May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

signer/core can't compile to wasm due to unix constrains
2 participants