Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eth/tracers/js: drop duktape engine #24934

Merged
merged 13 commits into from
May 23, 2022
Merged

eth/tracers/js: drop duktape engine #24934

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
ac3cede
eth/tracers: remove duktape tracer and deps
s1na May 19, 2022
d492dfa
rename goja file to tracer
s1na May 19, 2022
3ea8ff6
rename gojaTracer to jsTracer
s1na May 19, 2022
491574d
doc and more renaming
s1na May 19, 2022
bb75165
rename js tracer tests
s1na May 20, 2022
ff555f8
rm unused testcase field
s1na May 20, 2022
8953a23
merge duktape and goja wrapper types
s1na May 20, 2022
4485c99
Revert "rm unused testcase field"
s1na May 23, 2022
e7fb72e
Handle errors in native functions via interrupt
s1na May 23, 2022
9e15b7b
fixup test cases
s1na May 23, 2022
5d42fe2
fix race in Stop
s1na May 23, 2022
42accf4
fix lint err
s1na May 23, 2022
f8fbe3f
rename back to goja.go
s1na May 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "rm unused testcase field" 
This reverts commit ff555f8.
  • Loading branch information
@s1na
s1na committed May 23, 2022
commit 4485c999b45920a5a4a7f264ad1cab8bacb7bcad
9 changes: 3 additions & 6 deletions eth/tracers/js/tracer_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ func TestTracer(t *testing.T) {
for i, tt := range []struct {
code string
want string
fail string
}{
{ // tests that we don't panic on bad arguments to memory access
code: "{depths: [], step: function(log) { this.depths.push(log.memory.slice(-1,-2)); }, fault: function() {}, result: function() { return this.depths; }}",
Expand Down Expand Up @@ -137,12 +138,8 @@ func TestTracer(t *testing.T) {
want: `{"0":0,"1":0,"2":0,"3":0,"4":0,"5":0,"6":0,"7":0,"8":0,"9":0,"10":0,"11":0,"12":0,"13":0,"14":0,"15":0,"16":0,"17":0,"18":0,"19":0}`,
},
} {
have, err := execTracer(tt.code)
if err != "" {
t.Errorf("testcase %d: failed with error '%s'\n", i, err)
}
if tt.want != string(have) {
t.Errorf("testcase %d: expected return value to be '%s' got '%s'\n\tcode: %v", i, tt.want, string(have), tt.code)
if have, err := execTracer(tt.code); tt.want != string(have) || tt.fail != err {
t.Errorf("testcase %d: expected return value to be '%s' got '%s', error to be '%s' got '%s'\n\tcode: %v", i, tt.want, string(have), tt.fail, err, tt.code)
}
}
}
Expand Down