Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/devp2p/internal/ethtest: add support for eth/68 #26078

Merged
merged 5 commits into from
Nov 7, 2022
Merged

cmd/devp2p/internal/ethtest: add support for eth/68 #26078

merged 5 commits into from
Nov 7, 2022

Conversation

MariusVanDerWijden
Copy link
Member

Adds the eth/68 protocol version to the devp2p test suite

holiman
holiman approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman
Copy link
Contributor

holiman commented Nov 5, 2022 

cmd/devp2p/internal/ethtest/suite.go:527:40: unnecessary conversion (unconvert)
	announce := NewPooledTransactionHashes(NewPooledTransactionHashes{Types: types, Sizes: sizes, Hashes: hashes}

@fjl fjl changed the title cmd/devp2p/internal/ethtest: add eth68 to devp2p test suite cmd/devp2p/internal/ethtest: add support for eth/68 Nov 7, 2022
@fjl fjl merged commit 055528a into ethereum:master Nov 7, 2022
@fjl fjl added this to the 1.11.0 milestone Nov 7, 2022
shekhirin pushed a commit to shekhirin/go-ethereum that referenced this pull request Jun 6, 2023
@MariusVanDerWijden @fjl @shekhirin
cmd/devp2p/internal/ethtest: add support for eth/68 (ethereum#26078)
0db6906 
Co-authored-by: Felix Lange <fjl@twurst.com>
jonastheis pushed a commit to scroll-tech/go-ethereum that referenced this pull request Jun 7, 2024
@MariusVanDerWijden @jonastheis
cmd/devp2p/internal/ethtest: add support for eth/68 (ethereum#26078)
4847f7b 
Co-authored-by: Felix Lange <fjl@twurst.com>
 Conflicts:
	cmd/devp2p/internal/ethtest/helpers.go
omerfirmak pushed a commit to scroll-tech/go-ethereum that referenced this pull request Aug 6, 2024
@MariusVanDerWijden @omerfirmak
cmd/devp2p/internal/ethtest: add support for eth/68 (ethereum#26078)
4b7dc15 
Co-authored-by: Felix Lange <fjl@twurst.com>
 Conflicts:
	cmd/devp2p/internal/ethtest/helpers.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjl fjl fjl approved these changes

@holiman holiman holiman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@MariusVanDerWijden @holiman @fjl @ligi