Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth/tracers: small refactor for native tracers #26196

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

s1na
Copy link
Contributor

@s1na s1na commented Nov 16, 2022

Use noopTracer as a base for other native tracers to avoid extra boilerplate for unimplemented hooks.

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice. I suspect that pattern can be used in various test-places too.

Still, please leave a PR description next time 🙁

@holiman holiman added this to the 1.11.0 milestone Nov 16, 2022
@holiman holiman merged commit 64067fb into ethereum:master Nov 17, 2022
shekhirin pushed a commit to shekhirin/go-ethereum that referenced this pull request Jun 6, 2023
Use noopTracer as a base for other native tracers to avoid extra boilerplate for unimplemented hooks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants