Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ethdb/pebble: fix range compaction #26771

Merged
merged 2 commits into from
Feb 28, 2023
Merged

ethdb/pebble: fix range compaction #26771

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e678c9
ethdb/pebble: fix range compaction
rjl493456442 Feb 27, 2023
83807df
ethdb/pebble: add comment
rjl493456442 Feb 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
ethdb/pebble: add comment
  • Loading branch information
@rjl493456442
rjl493456442 committed Feb 27, 2023
commit 83807df1c6c035ef5e500c8631e2fd74e7671d0b
4 changes: 4 additions & 0 deletions ethdb/pebble/pebble.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,6 +365,10 @@ func (d *Database) Compact(start []byte, limit []byte) error {
// There is no special flag to represent the end of key range
// in pebble(nil in leveldb). Use an ugly hack to construct a
// large key to represent it.
rjl493456442 marked this conversation as resolved.
Show resolved Hide resolved
// Note any prefixed database entry will be smaller than this
// flag, as for trie nodes we need the 32 byte 0xff because
// there might be a shared prefix starting with a number of
// 0xff-s, so 32 ensures than only a hash collision could touch it.
// https://github.com/cockroachdb/pebble/issues/2359#issuecomment-1443995833
if limit == nil {
limit = bytes.Repeat([]byte{0xff}, 32)
Expand Down