Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: log message if DeriveFields returns error #27530

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

aaronbuchwald
Copy link
Contributor

This PR adds an error log in a case where the error was previously unchecked. This error should never happen and the error message is copied from https://github.com/ethereum/go-ethereum/blob/v1.12.0/core/rawdb/accessors_chain.go#L647

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman holiman changed the title Add error log for unchecked DeriveFields log core: error output on receipt DeriveFields Jun 22, 2023
@fjl fjl changed the title core: error output on receipt DeriveFields core: log message if DeriveFields returns error Jun 27, 2023
@fjl fjl merged commit d73eb87 into ethereum:master Jun 27, 2023
1 check passed
@fjl fjl added this to the 1.12.1 milestone Jun 27, 2023
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
This error will never happen, but if it ever does happen, we will at least see it.
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants