-
Notifications
You must be signed in to change notification settings - Fork 20k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eth/catalyst: reset to current header if chain is rewound (in dev mode) #27992
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
7246309
eth/catalyst: reset to current header if chain is rewinded
jsvisa dfd8a79
eth/catalyst: code review change
jsvisa 7afd003
Update eth/catalyst/simulated_beacon.go
jsvisa e3bb404
eth/catalyst: skip if finalized block is nil
jsvisa 998cec0
eth/catalyst: dry
jsvisa d853c71
set finalized block hash in SimulatedBeacon forkchoice state upon cha…
jwasinger f280444
don't terminate SimulatedBeacon sealing loops if sealBlock returns an…
jwasinger 1575c31
eth/catalyst: typo
jsvisa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
finalizedHash
can be nil, should have nil check here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it could happen in theory but should be extremely unlikely: a setHead which rolls back to before the latest finalized block would have to occur between the execution of line 147 and 148.