Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: remove the dependency from trie to triedb #28824

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

rjl493456442
Copy link
Member

@rjl493456442 rjl493456442 commented Jan 17, 2024

This pull request removes the dependency from trie package to triedb package. Although the reverse dependency (from "triedb" => "trie") is added for now, but it can be removed in a following PR.

@rjl493456442 rjl493456442 changed the title all: remote the dependency from trie to triedb all: remove the dependency from trie to triedb Jan 17, 2024
@rjl493456442 rjl493456442 force-pushed the triedb-pkg-2 branch 3 times, most recently from e31dae6 to 0146f2e Compare January 23, 2024 07:45
@rjl493456442 rjl493456442 marked this pull request as ready for review January 23, 2024 07:45
@holiman holiman requested a review from fjl January 23, 2024 20:11
@rjl493456442
Copy link
Member Author

rjl493456442 commented Feb 1, 2024

An opening question is about the package name. triedb is picked now as it's the database for storing trie nodes. But if we plan to integrate the states into it as well, probably this package name is no longer suitable?

@holiman holiman added this to the 1.13.13 milestone Feb 13, 2024
@holiman holiman merged commit fe91d47 into ethereum:master Feb 13, 2024
2 of 3 checks passed
jorgemmsilva pushed a commit to iotaledger/go-ethereum that referenced this pull request Jun 17, 2024
This change removes the dependency from trie package to triedb package.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants