trie: use go-verkle helper for speedier (*VerkleTrie).RollBackAccount #30242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjl493456442
reviewed
Aug 2, 2024
| // Delete all further code | ||
| for i, chunknr := uint64(32*128), uint64(128); i < codeSize; i, chunknr = i+32, chunknr+1 { | ||
| for i, chunknr := uint64(31*128), uint64(128); i < codeSize; i, chunknr = i+31*256, chunknr+256 { |
There was a problem hiding this comment.
If i understand correctly, the codeSize in the account header refers to the length of raw contract code;
After code chunkification, for each chunk we store 1 byte metadata and 31 bytes code? It's the reason you only count 31 bytes here?
Co-authored-by: Guillaume Ballet <3272758+gballet@users.noreply.github.com>
fjl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a performance improvement on the account-creation rollback code required for the archive node to support verkle. It uses the utility function
DeleteAtStemto remove code and account data per-group instead of doing it leaf by leaf.It also fixes an index bug, as code is chunked in 31-byte chunks, so comparing with the code size should use 31 as its stride.