Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added logic to show the account nonce on lookup #10

Merged
merged 2 commits into from
Nov 5, 2019

Conversation

409H
Copy link
Contributor

@409H 409H commented Oct 14, 2019

Closes issue #9

On address lookup, it will show the account nonce for each network.
image

@Enigmatic331
Copy link

Hi @409H - Thanks for the PR and sorry for the late reply.

Generally I think it's fine, though could we have the label reflect "Current Nonce"? Think that could be clearer in case it is misunderstood that the nonce is reflecting the tx's nonce.

Feel free to let me know what you think.

@409H
Copy link
Contributor Author

409H commented Nov 4, 2019

@Enigmatic331 I updated the label, good idea.

@khairulmax khairulmax merged commit 3056378 into etherscan:master Nov 5, 2019
@409H 409H deleted the en-account_nonce branch November 5, 2019 16:59
@dvy193 dvy193 mentioned this pull request Aug 11, 2021
Copy link

@Scheusal13 Scheusal13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants