swarm/storage/localstore: lock item address in collectGarbage iterator

ethersphere · Dec 21, 2018 · 95726d7 · 95726d7
1 parent 5edd22d
commit 95726d7
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/swarm/storage/localstore/gc.go b/swarm/storage/localstore/gc.go
@@ -79,6 +79,13 @@ func (db *DB) collectGarbage() (collectedCount int64, done bool, err error) {
 
 	done = true
 	err = db.gcIndex.Iterate(func(item shed.Item) (stop bool, err error) {
+		// protect parallel updates
+		unlock, err := db.lockAddr(item.Address)
+		if err != nil {
+			return false, err
+		}
+		defer unlock()
+
 		gcSize := atomic.LoadInt64(&db.gcSize)
 		if gcSize-collectedCount <= target {
 			return true, nil