This repository has been archived by the owner on Aug 2, 2021. It is now read-only.
swarm/network, swarm/storage: Preserve opentracing contexts #1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolash
force-pushed
the
fetcher-tracing-context
branch
from
08866d2
to
002cee3
Compare
nonsense
reviewed
Feb 8, 2019
nonsense
approved these changes
Feb 8, 2019
|
Great work! I ran the smoke tests on your branch and they are passing (meaning no regressions). This is a big improvement in terms of tracing.
|
skylenet
approved these changes
Feb 8, 2019
|
Submitted upstream ethereum/go-ethereum#19022 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an incremental part of #1181 whose description is:
Specifically, the effect of this PR should be that the current context path is in correct hierarchical order:
Furthermore, within the stream package it also makes sure the trace span finish executes after protocol message transmission has been completed (before it only measured the time it took to insert a message into the priority queue)