Merge pull request #14331 from timis1/JAVA-22498

JAVA-22498 Potential issue in "Difference Between FileReader and Buff…
eugenp · Jul 2, 2023 · fcb9877 · fcb9877
2 parents a642f80 + 64b06b0
commit fcb9877
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 8 deletions.
diff --git a/...-apis-2/src/test/java/com/baeldung/bufferedreadervsfilereader/BufferedReaderUnitTest.java b/...-apis-2/src/test/java/com/baeldung/bufferedreadervsfilereader/BufferedReaderUnitTest.java
@@ -3,18 +3,23 @@
 import static org.junit.jupiter.api.Assertions.assertEquals;
 
 import java.io.BufferedReader;
-import java.io.FileReader;
+import java.io.File;
 import java.io.IOException;
+import java.io.InputStreamReader;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.nio.file.Path;
 
-import org.junit.jupiter.api.Assertions;
-import org.testng.annotations.Test;
-public class BufferedReaderUnitTest {
+import org.junit.jupiter.api.Test;
+
+class BufferedReaderUnitTest {
 
     @Test
-    public void whenReadingAFile_thenReadsLineByLine() {
+    void whenReadingAFile_thenReadsLineByLine() {
         StringBuilder result = new StringBuilder();
 
-        try (BufferedReader br = new BufferedReader(new FileReader("src/test/resources/sampleText1.txt"))) {
+        final Path filePath = new File("src/test/resources/sampleText1.txt").toPath();
+        try (BufferedReader br = new BufferedReader(new InputStreamReader(Files.newInputStream(filePath), StandardCharsets.UTF_8))) {
             String line;
 
             while((line = br.readLine()) != null) {

diff --git a/...a-io-apis-2/src/test/java/com/baeldung/bufferedreadervsfilereader/FileReaderUnitTest.java b/...a-io-apis-2/src/test/java/com/baeldung/bufferedreadervsfilereader/FileReaderUnitTest.java
@@ -7,10 +7,10 @@
 
 import org.junit.jupiter.api.Test;
 
-public class FileReaderUnitTest {
+class FileReaderUnitTest {
 
     @Test
-    public void whenReadingAFile_thenReadsCharByChar() {
+    void whenReadingAFile_thenReadsCharByChar() {
         StringBuilder result = new StringBuilder();
 
         try (FileReader fr = new FileReader("src/test/resources/sampleText2.txt")) {