added a test for the become method #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eulertour
pushed a commit
that referenced
this pull request
Mar 3, 2021
* added many svg test images * Added test for the Rhomboid * Fixed multi-point lists of L type * Two more svg files * Also ignore pycharm-specific project information * Allow skipping of tests with a pytest_skip class attribute * Stubbed a couple tests out before rewrite * Rewrite of SVG path midlayer * refactored old test name * Added tests for two more files * Bugfix for absolute H/V paths * small refactor of cubics * Enabled correct quadratic bezier functionality. * Black formatting * Test the SVG smoothed curves (S and T) * handful more tests * Add all Discord svg tests * Update manim/mobject/types/vectorized_mobject.py Co-authored-by: Leo Torres <dleonardotn@gmail.com> * Apply suggestions from code review 1 Co-authored-by: Leo Torres <dleonardotn@gmail.com> * Remove files of questionable origin * rolled back review change due to ValueError * Added entries from the SVG Support github project * smaller fixes from review #1 * Enabled fill and stroke. * Troubles with the use of "currentcolor" - for now we wont support it * Minimize visual effect of downstream changes on Tex * Style changes ordered by Black * fixed background opacity handling * enable coloring of circles * Remove periodic table test (requires text) * Update documentation * refactored bare exception catch * Rolling back the pytest_skip functionality * Document some less obvious unit tests * fixing leo's rec * edit to penrose triangle test * Don't copy the list, copy the objects in the list. * black styling * Include defs in tree parsing * Update default svg values for visibility in test. * black formatting * Interpret RGB percentages * mild fix to for btd rebuild. * Force family update for classes that inherit SVGMobjects in order to preserve behavior. * Apply suggestions from code review 2 Co-authored-by: Naveen M K <naveen@syrusdark.website> Co-authored-by: Jason Villanueva <a@jsonvillanueva.com> * make static parsing methods into object methods, and add typing * Add typing to use_to_mobject which misled me earlier, and fix documentation merge error * Apply suggestions from code review 3 Co-authored-by: Naveen M K <naveen@syrusdark.website> * black fix * add types for quadratic bezier * prevent fail after matrix transform * Add UK Flag Test * black style * remove DEFAULT SVG STYLE and converted to inline argument. * Remove useless comments. * Refactor svg_mobject.py into multiple files. * documentation and typings * black styling * allow floats in rgb pct specification * parse floats like 2.4.3 into 2.4 0.3, with test * update typing for SUPPORTED_STYLING_ATTRIBUTES Co-authored-by: Naveen M K <naveen@syrusdark.website> * forgot import List from typings Co-authored-by: Leo Torres <dleonardotn@gmail.com> Co-authored-by: Naveen M K <naveen@syrusdark.website> Co-authored-by: Jason Villanueva <a@jsonvillanueva.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added an test for the become method.
Unfortunately, I could not directly commit to your pr-branch.
is this intended?