update tests

evanodell · Jul 3, 2017 · d7d7f76 · d7d7f76
1 parent c49f404
commit d7d7f76
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 7 deletions.
diff --git a/R/mnis_tidy.R b/R/mnis_tidy.R
@@ -1,6 +1,6 @@
 
 #' Functions to tidy up the variable names returned from the API, and turn dates and datetimes to POSIXct.
-#' @param df The tibble to tidy
+#' @param df The tibble to tidy.
 #' @param tidy_style The style to tidy the tibble with.
 #' @export
 #' @rdname mnis_tidy

diff --git a/man/mnis_tidy.Rd b/man/mnis_tidy.Rd
diff --git a/tests/testthat/test_all_members.R b/tests/testthat/test_all_members.R
@@ -1,12 +1,15 @@
 library(mnis)
-context("additional")
+context("all_members")
 
 
-test_that("mnis_additional returns expected format", {
+test_that("mnis_all_members returns expected format", {
 
     skip_on_cran()
 
     xmnisallmembers <- mnis_all_members(house = 'all', party = NULL, tidy = TRUE, tidy_style="snake_case")
+    expect_length(xmnisallmembers, 22)
+    expect_type(xmnisallmembers,"list")
+    expect_true(tibble::is_tibble(xmnisallmembers))
 
 
 })
diff --git a/tests/testthat/test_eligible.R b/tests/testthat/test_eligible.R
@@ -10,7 +10,7 @@ test_that("mnis_eligible returns expected format", {
   xmniselig <- mnis_eligible()
   expect_length(xmniselig, 23)
   expect_type(xmniselig, "list")
-  expect_true(nrow(xmniselig)==1456)
+  expect_true(nrow(xmniselig)==1455)
   expect_true(tibble::is_tibble(xmniselig))
 
 

diff --git a/tests/testthat/test_joined_between.R b/tests/testthat/test_joined_between.R
@@ -14,5 +14,3 @@ test_that("mnis_joined_between returns expected format", {
 
 })
 
-
-df2 <- mnis_tidy(df)