Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add resolve-extension-order #142

Merged
merged 1 commit into from
May 29, 2020

Conversation

viankakrisna
Copy link
Contributor

No description provided.

@evanw
Copy link
Owner

evanw commented May 27, 2020

This is an interesting feature. I'm not sure about the name --resolve-extension-order though. It's relatively long and I'm not sure I'd understand what it does given the name. What do you think about something like --implicit-extensions instead?

@viankakrisna
Copy link
Contributor Author

viankakrisna commented May 27, 2020

hmm that name is coming from the actual variable it's replacing in the resolver, webpack already has resolve.extensions which does the same thing https://webpack.js.org/configuration/resolve/

i think --resolve-extensions is fine if we want to shorten it. this would help anyone migrating from webpack, but i dont really have a strong preferences either way

@evanw
Copy link
Owner

evanw commented May 29, 2020

Good to know about the precedent from Webpack. In that case --resolve-extensions sounds fine to me.

@evanw evanw merged commit addc173 into evanw:master May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants