Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Godoc badge #177

Merged
merged 1 commit into from
Jun 11, 2020
Merged

Add Godoc badge #177

merged 1 commit into from
Jun 11, 2020

Conversation

tooolbox
Copy link
Contributor

Godoc is a common way for Go devs to look at a package. It only shows exported methods and types so you get a clear view of the API. Having a Godoc badge provides a handy shortcut.

I made the badge point at pkg/api since that is the main integration point and I'm guessing will see more use than pkg/cli.

@evanw
Copy link
Owner

evanw commented Jun 11, 2020

Sure, sounds good to me. I just moved the Go documentation over to godoc so the information and examples will be there too.

@evanw evanw merged commit ff9f10f into evanw:master Jun 11, 2020
@shilangyu
Copy link

shilangyu commented Jun 12, 2020

godoc.org has already been deprecated, the badge should point to pkg.go.dev instead. (new design of the badge is not yet available but is being worked on here)

@tooolbox
Copy link
Contributor Author

deprecated

(chiefly of a software feature) be usable but regarded as obsolete and best avoided, typically due to having been superseded.

Not really obsolete, not particularly best to avoid it, not yet superseded.

  1. New documentation site doesn't have all of the features of the old one yet.
  2. New documentation site has bugs not present in the old one.
  3. New badge isn't available yet, as you mention.

At some point it will be superseded, at which point this and many other projects will need to switch. Although, godoc will redirect anyway, so it's minor bookkeeping.

References:

@evanw
Copy link
Owner

evanw commented Jun 12, 2020

When I moved the documentation over I took a look at both and chose godoc.org because I think the presentation looks better. I'm going to leave it linking to godoc.org. It will redirect to pkg.go.dev anyway when pkg.go.dev is ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants