feat: support linux riscv64 LE architecture #2000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xeonacid
reviewed
Feb 8, 2022
evanw
reviewed
Feb 9, 2022
| @@ -22,6 +22,7 @@ export const knownUnixlikePackages: Record<string, string> = { | |||
| 'linux arm LE': 'esbuild-linux-arm', | |||
| 'linux arm64 LE': 'esbuild-linux-arm64', | |||
| 'linux ia32 LE': 'esbuild-linux-32', | |||
| 'linux riscv64 LE': 'esbuild-linux-riscv64', | |||
There was a problem hiding this comment.
riscv64 is not documented as something node ever returns for process.arch: https://nodejs.org/api/process.html#processarch:
process.archThe operating system CPU architecture for which the Node.js binary was compiled. Possible values are:
'arm','arm64','ia32','mips','mipsel','ppc','ppc64','s390','s390x','x32', and'x64'.
I'm wondering if node's documentation is wrong because this PR appears to indicate that node supports this architecture. I asked about that here: nodejs/node#41900.
evanw
added a commit
that referenced
this pull request
Feb 9, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Linux on RISC-V 64bit.
Is there anywhere I missed out?