-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mod: update go version in go mod
#2431
Conversation
@evanw Hi, PTAL~ |
No. Go 1.13 support is deliberate. It's for people that need it. |
|
There are versions of macOS older than macOS 10.13. See the link I already posted above: #2183
|
@evanw Yes, I mean
|
No. From https://go.dev/doc/go1.13:
|
Hi, I think |
That's the point. If you use new syntax from Go 1.18 (e.g. generics), then esbuild will fail to compile with Go 1.13. That's bad. Enforcing Go 1.13 syntax ensures esbuild can be compiled with Go 1.13.
Official esbuild releases are done with Go 1.18 (now Go 1.19) but you can build it yourself using an older Go compiler if you have an older OS. You obviously wouldn't use Go 1.18 to build for macOS 10.12 because Go 1.18 doesn't support macOS 10.12. |
Main Change
For now, we use Go version 1.18.4 to build in
makefile
.I think we can update
go version
ingo mod
to make it more clearer.