Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use system temp directory to download using npm and ignore temp directory remove errors #551

Merged
merged 2 commits into from
Nov 20, 2020
Merged

Use system temp directory to download using npm and ignore temp directory remove errors #551

merged 2 commits into from
Nov 20, 2020

Conversation

Djaler
Copy link
Contributor

@Djaler Djaler commented Nov 20, 2020

fixes #547

@Djaler Djaler changed the title Fix/547 Use system temp directory to download using npm and ignore temp directory remove errors Nov 20, 2020
evanw
evanw approved these changes Nov 20, 2020
View reviewed changes
Copy link
Owner

@evanw evanw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I wonder what the problem was. Maybe antivirus or something preventing the directory from being removed?

@evanw evanw merged commit ae16a0d into evanw:master Nov 20, 2020
evanw added a commit that referenced this pull request Nov 20, 2020
@evanw
cleanup after landing #551
ed2064b
@evanw evanw mentioned this pull request Aug 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanw evanw evanw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Install using npm failed because can't remove install folder
2 participants
@Djaler @evanw