Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: overload build definitions #561

Merged
merged 2 commits into from
Nov 25, 2020
Merged

types: overload build definitions #561

merged 2 commits into from
Nov 25, 2020

Conversation

lukeed
Copy link
Contributor

@lukeed lukeed commented Nov 25, 2020 •
edited
Loading

Adds TypeScript overload definitions for build so that write: false and incremental: true remove the conditional existence of their relevant BuildResult properties.

Closes #559

evanw
evanw approved these changes Nov 25, 2020
View reviewed changes
Copy link
Owner

@evanw evanw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This looks great. Thanks for doing this.

@evanw evanw merged commit fe795c9 into evanw:master Nov 25, 2020
@lukeed lukeed deleted the types/build branch November 25, 2020 21:53
@mk0x9 mk0x9 mentioned this pull request Jan 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanw evanw evanw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot invoke an object which is possibly 'undefined'
2 participants
@lukeed @evanw