Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Easee: wait for opmode to initialise #11342

Merged
merged 3 commits into from
Dec 30, 2023
Merged

Easee: wait for opmode to initialise #11342

merged 3 commits into from
Dec 30, 2023

Conversation

andig
Copy link
Member

@andig andig commented Dec 30, 2023 •
edited
Loading

Fix #11328

Note: waiting for opmode will still not ensure energy etc. initialised. Hence, PR update to wait for two roundtrips.

@andig andig added the enhancement New feature or request label Dec 30, 2023
GrimmiMeloni
GrimmiMeloni approved these changes Dec 30, 2023
View reviewed changes
Copy link
Sponsor Collaborator

@GrimmiMeloni GrimmiMeloni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Tested locally, configure now works.

@andig andig merged commit b887131 into master Dec 30, 2023
6 checks passed
@andig andig deleted the feature/easee-opmode branch December 30, 2023 12:11
andig added a commit that referenced this pull request Jan 2, 2024
@andig
Revert "Easee: wait for opmode to initialise (#11342)"
7819662 
This reverts commit b887131.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrimmiMeloni GrimmiMeloni GrimmiMeloni approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Easee: evcc configure fails
2 participants
@andig @GrimmiMeloni