Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easee: Fix panic on op mode update #11435

Merged
merged 3 commits into from
Jan 3, 2024

Conversation

GrimmiMeloni
Copy link
Sponsor Collaborator

fix #11431

Marking as draft while I test locally.

@andig
Copy link
Member

andig commented Jan 2, 2024

LGTM

@GrimmiMeloni
Copy link
Sponsor Collaborator Author

I'll have a build in a few mins to test and confirm.

@GrimmiMeloni
Copy link
Sponsor Collaborator Author

Easee's having some trouble these days. I cannot start my test builds due to some i/o timeout.
I realized in the process that the setting of the timeout for the http client is not effective. I have adjusted that. Need to rebuild though. On it.

@andig
Copy link
Member

andig commented Jan 2, 2024

Der Fix passt- lass uns den mergen?

@andig
Copy link
Member

andig commented Jan 2, 2024

@GrimmiMeloni den Teil mit dem Timeout verstehe ich nicht. Das sollte neutral sein.

@GrimmiMeloni
Copy link
Sponsor Collaborator Author

Ja. War eine Nebelkerze. Soweit ich es verstehe laufen wir mit diesem Change jetzt immer in das Timeout auf der Gegenseite hier.

https://github.com/GrimmiMeloni/evcc/blob/d75105e0d1f1e387def91200ddb0d2d34e51817f/charger/easee.go#L188

Frage ist warum. Wäre es möglich das wir den Channel schließen bevor dieser select startet?

@GrimmiMeloni GrimmiMeloni marked this pull request as ready for review January 2, 2024 20:48
@GrimmiMeloni GrimmiMeloni self-assigned this Jan 2, 2024
@GrimmiMeloni GrimmiMeloni added the bug Something isn't working label Jan 2, 2024
@GrimmiMeloni
Copy link
Sponsor Collaborator Author

OK. Sieht gut aus. Funktioniert hier. Sorry für den späten Feuerwehreinsatz, @andig

@dm82m
Copy link

dm82m commented Jan 2, 2024

Könnt ihr dann ne schnelle 0.123.5 raus bringen? Kann leider nicht auf die 0.123.2 zurück da ich auf Home Assistant addon bin

charger/easee.go Show resolved Hide resolved
@GrimmiMeloni
Copy link
Sponsor Collaborator Author

This change is solid. Working locally, car charging without panics and evcc charger also works so #11328 would be fixed by this as well.

@andig andig merged commit 2f267e7 into evcc-io:master Jan 3, 2024
6 checks passed
@GrimmiMeloni GrimmiMeloni deleted the easee/opModePanicFix branch January 6, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Easee: panic in ProductUpdate processing
3 participants