Fixed block marking as sent

evelynEdison · Jan 18, 2018 · b10d3ea · b10d3ea
1 parent ad31013
commit b10d3ea
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/packages/daemons/disseminator.go b/packages/daemons/disseminator.go
@@ -155,8 +155,8 @@ func sendHashesResp(resp []byte, w io.Writer, logger *log.Entry) error {
 	case lr == 0:
 		return nil
 	// We got response that mean that node doesn't know about some transactions. We need to send them
-	case lr > consts.HashSize:
-		for len(resp) > consts.HashSize {
+	case lr >= consts.HashSize:
+		for len(resp) >= consts.HashSize {
 			// Parse the list of requested transactions
 			txHash := converter.BytesShift(&resp, consts.HashSize)
 			tr := &model.Transaction{}

diff --git a/packages/model/info_block.go b/packages/model/info_block.go
@@ -39,7 +39,7 @@ func (ib *InfoBlock) Create(transaction *DbTransaction) error {
 
 // MarkSent update model sent field
 func (ib *InfoBlock) MarkSent() error {
-	return DBConn.Model(ib).Update("sent", "1").Error
+	return DBConn.Model(ib).Update("sent", 1).Error
 }
 
 // BlockGetUnsent returns InfoBlock

diff --git a/packages/tcpserver/type1.go b/packages/tcpserver/type1.go
@@ -139,7 +139,7 @@ func getUnknownTransactions(buf *bytes.Buffer) ([]byte, error) {
 	var needTx []byte
 	for buf.Len() > 0 {
 		newDataTxHash := buf.Next(consts.HashSize)
-		if len(newDataTxHash) == 0 {
+		if len(newDataTxHash) != consts.HashSize {
 			log.WithFields(log.Fields{"len": len(newDataTxHash), "type": consts.ProtocolError}).Error("wrong transactions hash size")
 			return nil, errors.New("wrong transactions hash size")
 		}