Efrs 1174/bug f ix subject scrolling of the list of uploaded file does not work correctly #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/ removing mat-list-options and added custom html/css
… that change event can be triggered even if will try to upload the same file
…r continues infinite scrolling
|
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheckcla in this Pull Request |
isobolev
reviewed
Dec 6, 2021
| @@ -55,6 +61,12 @@ export class CollectionManagerSubjectLeftContainerComponent implements OnInit { | |||
| this.subjectsList$ = this.collectionLeftFacade.subjectsList$; | |||
| this.isPending$ = this.collectionLeftFacade.isPending$; | |||
| this.apiKey$ = this.collectionLeftFacade.apiKey$; | |||
| this.collectionItemsSubs = combineLatest([this.currentSubject$, this.collectionRightFacade.collectionItems$]) | |||
| .pipe( | |||
| map(([, collection]) => collection.filter(item => item.status === CircleLoadingProgressEnum.InProgress)), | |||
There was a problem hiding this comment.
is there a need for combineLatest since we are not using the result of this.currentSubject$?
isobolev
approved these changes
Dec 7, 2021
smchedlidze826
deleted the
EFRS-1174/BugFIx-Subject-scrolling-of-the-list-of-uploaded-file-does-not-work-correctly
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.