Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 MAINTAIN: Minor fixes #585

Merged
merged 2 commits into from
Jun 14, 2022
Merged

🔧 MAINTAIN: Minor fixes #585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
660c6eb
🔧 MAINTAIN: Minor fixes
chrisjsewell Jun 13, 2022
b3b7d68
Update dc_validators.py
chrisjsewell Jun 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion myst_parser/mdit_to_docutils/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@ def add_line_and_source_path_r(
"""
for node in nodes:
self.add_line_and_source_path(node, token)
for child in node.traverse():
for child in findall(node)():
self.add_line_and_source_path(child, token)

def update_section_level_state(self, section: nodes.section, level: int) -> None:
Expand Down
6 changes: 1 addition & 5 deletions myst_parser/sphinx_ext/myst_refs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,11 +151,7 @@ def resolve_myst_ref(
except NotImplementedError:
# the domain doesn't yet support the new interface
# we have to manually collect possible references (SLOW)
if not (
getattr(domain, "__module__", "").startswith("sphinx.")
# TODO glue can be removed when myst-nb fixed
or "glue" in getattr(domain, "__module__", "")
):
if not (getattr(domain, "__module__", "").startswith("sphinx.")):
logger.warning(
f"Domain '{domain.__module__}::{domain.name}' has not "
"implemented a `resolve_any_xref` method [myst.domains]",
Expand Down