-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ NEW: Emits sphinx include-read event #887
✨ NEW: Emits sphinx include-read event #887
Conversation
Thanks for submitting your first pull request! You are awesome! 🤗 |
a81a9a3
to
4f4624d
Compare
…thon 3.12 Also added test for included files that are not inside the source directory
Sorry about the noise, I forgot to test against older Python versions. Grateful for any feedback! |
cheers will have a look soon |
Any chance to take a look yet? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #887 +/- ##
==========================================
+ Coverage 90.10% 90.12% +0.01%
==========================================
Files 24 24
Lines 3377 3383 +6
==========================================
+ Hits 3043 3049 +6
Misses 334 334
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sorted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good thanks!
Awesome, thanks! |
Adds emission of Sphinx
include-read
events while processing include directives, closes #881.include-read
If there is a better way to restrict the test to Sphinx>=7.5.2, please let me know.