Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basics concept #278

Merged
merged 8 commits into from
May 8, 2023
Merged

Basics concept #278

merged 8 commits into from
May 8, 2023

Conversation

lpil
Copy link
Sponsor Member

@lpil lpil commented May 8, 2023 •
edited
Loading

Adapted from the Elixir and Elm basics concept.

I've removed all the existing "practices" config values as they were unthought and a bit of a mess. We can re-add them intentionally as new concepts are added.

@lpil lpil requested review from ErikSchierboom and a team May 8, 2023 11:18
@lpil lpil mentioned this pull request May 8, 2023
Merged
@hayleigh-dot-work
Copy link

The contents of concepts/basics/about.md, concepts/basics/introduction.md, and exercises/concept/lasagna/.docs/introduction.md are all the same, is that right?

@lpil
Copy link
Sponsor Member Author

lpil commented May 8, 2023

The contents of concepts/basics/about.md, concepts/basics/introduction.md, and exercises/concept/lasagna/.docs/introduction.md are all the same, is that right?

Yup, that's right. We can add more info to about.md if we want, but it doesn't get shown much so Erik said not to worry about it much initially.

hayleigh-dot-work
hayleigh-dot-work approved these changes May 8, 2023
View reviewed changes
Copy link

@hayleigh-dot-work hayleigh-dot-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nothing deal-breaking.

exercises/concept/lasagna/.docs/instructions.md Outdated Show resolved Hide resolved
exercises/concept/lasagna/.meta/design.md Outdated Show resolved Hide resolved
exercises/concept/lasagna/.docs/introduction.md Show resolved Hide resolved
@lpil lpil merged commit 4e93cd7 into main May 8, 2023
@lpil lpil deleted the basics branch May 8, 2023 12:49
@lpil lpil mentioned this pull request May 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giacomocavalieri giacomocavalieri giacomocavalieri left review comments

@hayleigh-dot-work hayleigh-dot-work hayleigh-dot-work approved these changes

@ErikSchierboom ErikSchierboom Awaiting requested review from ErikSchierboom

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lpil @hayleigh-dot-work @giacomocavalieri