Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing test for low-level full mana requirement Role Playing Game #434

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

lennnerd
Copy link
Contributor

The problem description states: If they player's level is below 10, their mana should be None. One of the top results did not implement this requirement due to a missing test.

This PR modifies a test verifying that low level players get their mana set to None.

@Reviewer: If preferred, i can also add a new test instead modifying the current test.

The problem description states: `If they player's level is below 10, their mana should be None`. One of the top results did not implement this requirement due to a missing test. 

This PR adds a test verifying that low level players get their `mana` set to `None`.
Copy link

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@lpil
Copy link
Sponsor Member

lpil commented Mar 22, 2024

Perhaps removing that requirement would be best. It's less disruptive and it doesn't teach anything in particular.

@lennnerd
Copy link
Contributor Author

Fair point.

Personally, as a beginner I quite liked the aspect of trying to reduce nesting with the extra mana requirement. But the less disruptive change is changing the docs. Its your call. I adapted the PR.

Copy link
Sponsor Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 💜

@lpil lpil merged commit 35b90af into exercism:main Mar 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants