Make fields public #283
Merged
Make fields public #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanislav-tkach
approved these changes
Aug 2, 2017
dj8yfo
reviewed
Aug 4, 2017
There was a problem hiding this comment.
@alekseysidorov is there a need to make TxLocation fields public?
| pub block: Block, | ||
| /// List of precommit for this block. | ||
| pub precommits: Vec<Precommit>, | ||
| /// List of hashes for transactions that was executed into this block. |
|
The |
|
@alekseysidorov review plz. |
|
But location field it |
alekseysidorov
approved these changes
Aug 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #278
Closes #279