Skip to content

Commit

Permalink
examples: use 1-based visitor count in cookie-sessions
Browse files Browse the repository at this point in the history
closes #3312
  • Loading branch information
hiowenluke authored and dougwilson committed Jul 26, 2017
1 parent 43dff4c commit 5e16f40
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
5 changes: 2 additions & 3 deletions examples/cookie-sessions/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,8 @@ app.use(count);

// custom middleware
function count(req, res) {
req.session.count = req.session.count || 0;
var n = req.session.count++;
res.send('viewed ' + n + ' times\n');
req.session.count = (req.session.count || 0) + 1
res.send('viewed ' + req.session.count + ' times\n')
}

/* istanbul ignore next */
Expand Down
6 changes: 3 additions & 3 deletions test/acceptance/cookie-sessions.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ describe('cookie-sessions', function () {
it('should display no views', function (done) {
request(app)
.get('/')
.expect(200, 'viewed 0 times\n', done)
.expect(200, 'viewed 1 times\n', done)
})

it('should set a session cookie', function (done) {
Expand All @@ -20,12 +20,12 @@ describe('cookie-sessions', function () {
it('should display 1 view on revisit', function (done) {
request(app)
.get('/')
.expect(200, 'viewed 0 times\n', function (err, res) {
.expect(200, 'viewed 1 times\n', function (err, res) {
if (err) return done(err)
request(app)
.get('/')
.set('Cookie', getCookies(res))
.expect(200, 'viewed 1 times\n', done)
.expect(200, 'viewed 2 times\n', done)
})
})
})
Expand Down

0 comments on commit 5e16f40

Please sign in to comment.