Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

req.subdomains tests fail in Windows #1600

Closed
mcandre opened this issue May 3, 2013 · 1 comment
Closed

req.subdomains tests fail in Windows #1600

mcandre opened this issue May 3, 2013 · 1 comment

Comments

@mcandre
Copy link

mcandre commented May 3, 2013

Trace:

$ mocha test/req.subdomains.js

  .....

  × 3 of 5 tests failed:

  1) req .subdomains when present should return an array:
     Error: expected '["ferrets","tobi"]' response body, got '[\n  "ferrets",\n  "tobi"\n]'
      at Test.assert (c:\Documents and Settings\apenneba\Desktop\src\express\node_modules\supertest\lib\test.js:177:21)
      at c:\Documents and Settings\apenneba\Desktop\src\express\node_modules\supertest\lib\test.js:124:10
      at Test.Request.callback (c:\Documents and Settings\apenneba\Desktop\src\express\node_modules\supertest\node_modules\superagent\lib\node\index.js:575:3)
      at Test.<anonymous> (c:\Documents and Settings\apenneba\Desktop\src\express\node_modules\supertest\node_modules\superagent\lib\node\index.js:133:10)
      at Test.EventEmitter.emit (events.js:95:17)
      at IncomingMessage.<anonymous> (c:\Documents and Settings\apenneba\Desktop\src\express\node_modules\supertest\node_modules\superagent\lib\node\index.js:703:12)
      at IncomingMessage.EventEmitter.emit (events.js:117:20)
      at _stream_readable.js:883:14
      at process._tickCallback (node.js:415:13)

  2) req .subdomains when subdomain offset is set when subdomain offset is zero should return an array with the whole domain:
     Error: expected '["com","example","sub","ferrets","tobi"]' response body, got '[\n
 "com",\n  "example",\n  "sub",\n  "ferrets",\n  "tobi"\n]'
      at Test.assert (c:\Documents and Settings\apenneba\Desktop\src\express\node_modules\supertest\lib\test.js:177:21)
      at c:\Documents and Settings\apenneba\Desktop\src\express\node_modules\supertest\lib\test.js:124:10
      at Test.Request.callback (c:\Documents and Settings\apenneba\Desktop\src\express\node_modules\supertest\node_modules\superagent\lib\node\index.js:575:3)
      at Test.<anonymous> (c:\Documents and Settings\apenneba\Desktop\src\express\node_modules\supertest\node_modules\superagent\lib\node\index.js:133:10)
      at Test.EventEmitter.emit (events.js:95:17)
      at IncomingMessage.<anonymous> (c:\Documents and Settings\apenneba\Desktop\src\express\node_modules\supertest\node_modules\superagent\lib\node\index.js:703:12)
      at IncomingMessage.EventEmitter.emit (events.js:117:20)
      at _stream_readable.js:883:14
      at process._tickCallback (node.js:415:13)

  3) req .subdomains when subdomain offset is set when present should return an array:
     Error: expected '["ferrets","tobi"]' response body, got '[\n  "ferrets",\n  "tobi"\n]'
      at Test.assert (c:\Documents and Settings\apenneba\Desktop\src\express\node_modules\supertest\lib\test.js:177:21)
      at c:\Documents and Settings\apenneba\Desktop\src\express\node_modules\supertest\lib\test.js:124:10
      at Test.Request.callback (c:\Documents and Settings\apenneba\Desktop\src\express\node_modules\supertest\node_modules\superagent\lib\node\index.js:575:3)
      at Test.<anonymous> (c:\Documents and Settings\apenneba\Desktop\src\express\node_modules\supertest\node_modules\superagent\lib\node\index.js:133:10)
      at Test.EventEmitter.emit (events.js:95:17)
      at IncomingMessage.<anonymous> (c:\Documents and Settings\apenneba\Desktop\src\express\node_modules\supertest\node_modules\superagent\lib\node\index.js:703:12)
      at IncomingMessage.EventEmitter.emit (events.js:117:20)
      at _stream_readable.js:883:14
      at process._tickCallback (node.js:415:13)
@jonathanong
Copy link
Member

can anyone confirm? i don't have a windows machine to check

jonathanong added a commit that referenced this issue Sep 19, 2013
rlidwka pushed a commit to rlidwka/express that referenced this issue Aug 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants