Change to crypto.pbkdf2 in Node v0.10 broke auth example #1571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 5, 2013
tj
added a commit
that referenced
this pull request
Apr 13, 2013
Change to crypto.pbkdf2 in Node v0.10 broke auth example
rlidwka
pushed a commit
to rlidwka/express
that referenced
this pull request
Aug 6, 2014
Change to crypto.pbkdf2 in Node v0.10 broke auth example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
crypto.pbkdf2has changed from returning a String in Node v0.8 to a SlowBuffer in Node v0.10 (nodejs/node-v0.x-archive#5003) effectively breaking the authentication scheme used in the auth example (not to mention https://github.com/visionmedia/node-pwd).The change causes the line
if (hash == user.hash) return fn(null, user);in the app.jsauthenticationfunction to always evaluate asfalseusing Node v0.10 (#1559).Using the recommendations from (nodejs/node-v0.x-archive#5003) I modified the hash function in pass.js to return a base64 encoded hash at all times fixing the issue using Node v0.10 and not breaking the example using Node v0.8 (tested both).