Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix encoding problem when generating extent reports #298

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

EvaSRGitHub
Copy link

When write the extent report In BufferedWriterWriter.java the ‘write’ method use the default system encoding instead of what the user is set in reporter.config().setEncodint() or to use the default encoding set to be “UTF-8” in FileReporterConfig.java.

@codecov
Copy link

codecov bot commented May 7, 2021

Codecov Report

Merging #298 (69a5597) into master (6d004b2) will increase coverage by 0.01%.
The diff coverage is 80.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #298      +/-   ##
============================================
+ Coverage     78.10%   78.12%   +0.01%     
  Complexity      493      493              
============================================
  Files            89       89              
  Lines          1544     1545       +1     
  Branches        128      128              
============================================
+ Hits           1206     1207       +1     
  Misses          269      269              
  Partials         69       69              
Impacted Files Coverage Δ Complexity Δ
...ntstack/extentreports/io/BufferedWriterWriter.java 77.77% <50.00%> (ø) 3.00 <1.00> (ø)
...k/extentreports/reporter/AbstractFileReporter.java 76.59% <100.00%> (+0.50%) 11.00 <0.00> (ø)
...ck/extentreports/reporter/ExtentSparkReporter.java 85.18% <100.00%> (ø) 13.00 <0.00> (ø)
...k/extentreports/templating/FreemarkerTemplate.java 85.71% <100.00%> (ø) 5.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d004b2...69a5597. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant