Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internalize GetFableModulesFromDir & GetFableModulesFromProject #3724

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Internalize GetFableModulesFromDir & GetFableModulesFromProject #3724

merged 2 commits into from
Jan 30, 2024

Conversation

nojaf
Copy link
Member

@nojaf nojaf commented Jan 30, 2024

I had a bit of a hard time following where evaluateOnly is being used.
Turns out CrackerOptions.GetFableModulesFromProject is not used outside ProjectCracker.

MangelMaxime
MangelMaxime requested changes Jan 30, 2024
View reviewed changes
Copy link
Member

@MangelMaxime MangelMaxime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly this PR, it is to avoid exposing a static member?

src/Fable.Compiler/ProjectCracker.fs Outdated Show resolved Hide resolved
src/Fable.Compiler/ProjectCracker.fs Show resolved Hide resolved
@MangelMaxime MangelMaxime merged commit 2033cd3 into fable-compiler:main Jan 30, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MangelMaxime MangelMaxime MangelMaxime requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nojaf @MangelMaxime