Skip to content

Commit

Permalink
Update Guava to 30.1-jre and Jib-Core to 0.18.0 (#1475)
Browse files Browse the repository at this point in the history
Signed-off-by: Rohan Kumar <rohaan@redhat.com>
  • Loading branch information
rohanKanojia authored May 23, 2021
1 parent a05bcd1 commit eb89183
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 6 deletions.
1 change: 1 addition & 0 deletions doc/changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
- A placeholder in docker.image.tag isn't replaced by the final result when used during docker:build ([1468](https://github.com/fabric8io/docker-maven-plugin/issues/1468))
- Add a property(`outputFile`) to dump the output of Docker commands to file ([1472]https://github.com/fabric8io/docker-maven-plugin/pull/1472)
- Add pulling of `cacheFrom` images during build ([1457](https://github.com/fabric8io/docker-maven-plugin/issues/1457))
- Update Guava to 30.1-jre and Jib-Core to 0.18.0 ([1475](https://github.com/fabric8io/docker-maven-plugin/pull/1475))

* **0.35.0** (2021-04-04)
- Building 'spring-boot-with-jib' sample fails with NoSuchMethodError ([1384](https://github.com/fabric8io/docker-maven-plugin/issues/1384))
Expand Down
4 changes: 2 additions & 2 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
<maven.version>3.3.9</maven.version>
<jmockit.version>1.43</jmockit.version>
<surefire.version>3.0.0-M2</surefire.version>
<jib-core.version>0.15.0</jib-core.version>
<jib-core.version>0.18.0</jib-core.version>
<httpclient.version>4.5.10</httpclient.version>
<excludedGroups>io.fabric8.maven.docker.UnixOnlyTests</excludedGroups>
<project.build.outputTimestamp>2020-11-14T11:57:00Z</project.build.outputTimestamp>
Expand Down Expand Up @@ -176,7 +176,7 @@
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
<version>29.0-jre</version>
<version>30.1-jre</version>
</dependency>

<dependency>
Expand Down
4 changes: 2 additions & 2 deletions samples/spring-boot-with-jib/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
</parent>

<artifactId>dmp-sample-spring-boot-jib</artifactId>
<version>0.33-SNAPSHOT</version>
<packaging>jar</packaging>

<description>Docker Maven Plugin Example with Spring Boot With Build Mode JIB</description>
Expand All @@ -34,6 +33,7 @@
<docker.build.jib>true</docker.build.jib>
<docker.user>fabric8</docker.user>
<spring.version>2.3.3.RELEASE</spring.version>
<dmp.version>${project.version}</dmp.version>
</properties>

<dependencies>
Expand Down Expand Up @@ -84,7 +84,7 @@
<plugin>
<groupId>io.fabric8</groupId>
<artifactId>docker-maven-plugin</artifactId>
<version>0.33-SNAPSHOT</version>
<version>${dmp.version}</version>
<configuration>
<images>
<image>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ static ImageFormat getImageFormat(String jibImageFormat) {
}

private static void submitPushToJib(TarImage baseImage, RegistryImage targetImage, ExecutorService jibBuildExecutor, Logger logger) throws InterruptedException, ExecutionException, RegistryException, CacheDirectoryCreationException, IOException {
Jib.from(baseImage).containerize(Containerizer.to(targetImage)
Jib.from(baseImage).setCreationTime(Instant.now()).containerize(Containerizer.to(targetImage)
.setAllowInsecureRegistries(true)
.setExecutorService(jibBuildExecutor)
.addEventHandler(LogEvent.class, log(logger))
Expand Down Expand Up @@ -357,4 +357,4 @@ private static String generateProgressBar(double progress) {
.append("% complete")
.toString();
}
}
}

0 comments on commit eb89183

Please sign in to comment.