Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flow typechecking as a webpack plugin #1152

Closed
wants to merge 75 commits into from
Closed

Add flow typechecking as a webpack plugin #1152

wants to merge 75 commits into from

Commits on Dec 14, 2016

  1. Setup a plugin to run a flow checking lifecycle 

    This will only run if a @flow annotation is seen:
- At the first @flow file found:
  - Write a .flowconfig if none exists
  - [Not done yet] Run flow-typed install
  - [Not done yet] Start a flow instance
- When a file with an @flow comment changes during a compilation:
  - [Not done yet] Run a flow check
  - If there are some errors in flow:
    - If CI: output as an error
    - If not CI: output as a warning
    @rricard
    rricard committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    10ec304 View commit details
    Browse the repository at this point in the history

  2. Make flow fail on CI builds 

    We don't need complex logic with process.env on the plugin side, we let the build script figure this out!
    @rricard
    rricard committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    c7eacf8 View commit details
    Browse the repository at this point in the history

  3. Run flow as a server and check with status

    @rricard
    rricard committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    b0c39e7 View commit details
    Browse the repository at this point in the history

  4. Add flow ignore comment to the start hints

    @rricard
    rricard committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    de16269 View commit details
    Browse the repository at this point in the history

  5. Add flow-typed resolution at start

    @rricard
    rricard committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    31b2e04 View commit details
    Browse the repository at this point in the history

  6. Reset server stderr on restart

    @rricard
    rricard committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    d4763a5 View commit details
    Browse the repository at this point in the history

  7. Move options as explicit props of the plugin

    @rricard
    rricard committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    2f34a67 View commit details
    Browse the repository at this point in the history

  8. Use arrow functions

    @rricard
    rricard committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    79b3b86 View commit details
    Browse the repository at this point in the history

  9. Refactor using promises and no class attrs

    @rricard
    rricard committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    d004f2d View commit details
    Browse the repository at this point in the history

  10. Add documentation for out-of-the-box flow

    @rricard
    rricard committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    ec8d230 View commit details
    Browse the repository at this point in the history

  11. Schedule project init to complete before 1st check

    @rricard
    rricard committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    bb39b19 View commit details
    Browse the repository at this point in the history

  12. Process code-based flow checks

    @rricard
    rricard committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    8878502 View commit details
    Browse the repository at this point in the history

  13. Get flow version internally without config

    @rricard
    rricard committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    6a5cfc1 View commit details
    Browse the repository at this point in the history

  14. Check global flow version 

    If a mismatch occurs, the DX will be bad, we should tell it to the user
    @rricard
    rricard committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    513c0a9 View commit details
    Browse the repository at this point in the history

  15. Add flow-typed to gitignore automatically

    @rricard
    rricard committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    719ac82 View commit details
    Browse the repository at this point in the history

  16. Add optional flow to end to end testing

    @rricard
    rricard committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    c76f15e View commit details
    Browse the repository at this point in the history

  17. Run flow even if init failed

    @rricard
    rricard committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    ba7a05a View commit details
    Browse the repository at this point in the history

  18. Remove fbjs ignores now that it's fixed

    @rricard
    rricard committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    2362346 View commit details
    Browse the repository at this point in the history

  19. Remove flow-typed lib import (known by default!)

    @rricard
    rricard committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    f83fa6a View commit details
    Browse the repository at this point in the history

  20. In e2e: assert flow is correctly showing errors

    @rricard
    rricard committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    f42c5cc View commit details
    Browse the repository at this point in the history

  21. Only change gitignore if we create a flowconfig

    @rricard
    rricard committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    f9ae1f0 View commit details
    Browse the repository at this point in the history

  22. Ensure the init promise is correctly triggered

    @rricard
    rricard committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    c5e2102 View commit details
    Browse the repository at this point in the history

  23. Don't create an uncatched promise

    @rricard
    rricard committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    e4e2111 View commit details
    Browse the repository at this point in the history

  24. Don't reinit flow in a child compilation

    @rricard
    rricard committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    f9bf33d View commit details
    Browse the repository at this point in the history

  25. Remove flow-typed/ dir assertion 

    Was failing intermittently
    @rricard
    rricard committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    4448e98 View commit details
    Browse the repository at this point in the history

  26. Reapply a lost change from facebook#1233 during rebase

    @rricard
    rricard committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    db929a1 View commit details
    Browse the repository at this point in the history

  27. Consistent ESLint capitalization

    @rricard
    rricard committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    eac318d View commit details
    Browse the repository at this point in the history

  28. Run flow version check before the rest

    @rricard
    rricard committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    054357f View commit details
    Browse the repository at this point in the history

  29. Transmit via warnings why Flow was disabled

    @rricard
    rricard committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    b3e5609 View commit details
    Browse the repository at this point in the history

  30. Don't fail on tarball react-scripts

    @rricard
    rricard committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    cabeadb View commit details
    Browse the repository at this point in the history

  31. Celebrate when the flow tests pass!

    @rricard
    rricard committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    fa6d3c8 View commit details
    Browse the repository at this point in the history

  32. Show npm commands in cyan

    @rricard
    rricard committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    05ae460 View commit details
    Browse the repository at this point in the history

  33. "Hide" flow err suppression in dev utils

    @rricard
    rricard committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    e30a959 View commit details
    Browse the repository at this point in the history

  34. Only highlight the npm word

    @rricard
    rricard committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    3ed5f2c View commit details
    Browse the repository at this point in the history

  35. Make flow-typed provision sequential

    @rricard
    rricard committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    026e581 View commit details
    Browse the repository at this point in the history

  36. Redisign & simplify flow e2e tests

    @rricard
    rricard committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    6e44124 View commit details
    Browse the repository at this point in the history

  37. Correctly ignore invalid comp errors

    @rricard
    rricard committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    3047218 View commit details
    Browse the repository at this point in the history

  38. Add ref to an issue comment on the silencing

    @rricard
    rricard committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    09c2c13 View commit details
    Browse the repository at this point in the history

  39. Remove debugging command in e2e.sh

    @rricard
    rricard committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    3949fb3 View commit details
    Browse the repository at this point in the history

  40. Remove planning to add the feature in doc[ci skip] 

    It's there now!
    @rricard
    rricard committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    159638b View commit details
    Browse the repository at this point in the history

  41. No build test for flow (duplicate)

    @rricard
    rricard committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    5105c29 View commit details
    Browse the repository at this point in the history

  42. Simpler second flow test 

    This also let it test the idempotence of the flow addition
    @rricard
    rricard committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    4fa4569 View commit details
    Browse the repository at this point in the history

  43. After eject, the .flowconfig should stay

    @rricard
    rricard committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    ba483c6 View commit details
    Browse the repository at this point in the history

  44. Use Flow 0.37.0

    @rricard
    rricard committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    a48e8c3 View commit details
    Browse the repository at this point in the history

  45. Directly target the flow-typed executable 

    Not the .bin version
    @rricard
    rricard committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    9e1957e View commit details
    Browse the repository at this point in the history

  46. Revert "Directly target the flow-typed executable" 

    This reverts commit 9e1957e.
    @rricard
    rricard committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    c834095 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2016

  1. Find flow-typed in the npm flat struct

    @rricard
    rricard committed Dec 15, 2016
    Configuration menu
    Copy the full SHA
    f5d3982 View commit details
    Browse the repository at this point in the history

  2. Define flow-typed path with project root

    @rricard
    rricard committed Dec 15, 2016
    Configuration menu
    Copy the full SHA
    cfc1115 View commit details
    Browse the repository at this point in the history

  3. Resolve flow-typed via module resolution 

    And boot it like the CLI boots in flow-typed sources
    @rricard
    rricard committed Dec 15, 2016
    Configuration menu
    Copy the full SHA
    030f7c1 View commit details
    Browse the repository at this point in the history

  4. Remove unneeded complexity

    @rricard
    rricard committed Dec 15, 2016
    Configuration menu
    Copy the full SHA
    37444f2 View commit details
    Browse the repository at this point in the history

  5. Make run flow-typed executable

    @rricard
    rricard committed Dec 15, 2016
    Configuration menu
    Copy the full SHA
    08ca783 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2017

  1. Don't put flow-typed on gitignore

    @Gregoor @Timer
    Gregoor authored and Timer committed Apr 22, 2017
    Configuration menu
    Copy the full SHA
    51cca10 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into flow

    @rricard @Timer
    rricard authored and Timer committed Apr 22, 2017
    Configuration menu
    Copy the full SHA
    7e33f9d View commit details
    Browse the repository at this point in the history

  3. Appease linter

    @Timer
    Timer committed Apr 22, 2017
    Configuration menu
    Copy the full SHA
    a3a78f7 View commit details
    Browse the repository at this point in the history

  4. Update flow

    @Timer
    Timer committed Apr 22, 2017
    Configuration menu
    Copy the full SHA
    eb9e341 View commit details
    Browse the repository at this point in the history

  5. Add basic flow type checking

    @Timer
    Timer committed Apr 22, 2017
    Configuration menu
    Copy the full SHA
    137f59f View commit details
    Browse the repository at this point in the history

  6. Adjust format function

    @Timer
    Timer committed Apr 22, 2017
    Configuration menu
    Copy the full SHA
    2fd2dbc View commit details
    Browse the repository at this point in the history

  7. Remove flow-typed stub

    @Timer
    Timer committed Apr 22, 2017
    Configuration menu
    Copy the full SHA
    7c5749d View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2017

  1. Use access instead of stat to prevent dual-compile

    @Timer
    Timer committed Apr 23, 2017
    Configuration menu
    Copy the full SHA
    f4299ef View commit details
    Browse the repository at this point in the history

  2. Add some friendly comments

    @Timer
    Timer committed Apr 23, 2017
    Configuration menu
    Copy the full SHA
    a3fb2df View commit details
    Browse the repository at this point in the history

  3. Lock down flow version

    @Timer
    Timer committed Apr 23, 2017
    Configuration menu
    Copy the full SHA
    de99610 View commit details
    Browse the repository at this point in the history

  4. Update comment logs

    @Timer
    Timer committed Apr 23, 2017
    Configuration menu
    Copy the full SHA
    29628ef View commit details
    Browse the repository at this point in the history

  5. Remove old method

    @Timer
    Timer committed Apr 23, 2017
    Configuration menu
    Copy the full SHA
    30494dc View commit details
    Browse the repository at this point in the history

  6. Remove from e2e

    @Timer
    Timer committed Apr 23, 2017
    Configuration menu
    Copy the full SHA
    f850266 View commit details
    Browse the repository at this point in the history

  7. Check flow version for performance

    @Timer
    Timer committed Apr 23, 2017
    Configuration menu
    Copy the full SHA
    8d1f515 View commit details
    Browse the repository at this point in the history

  8. Remove warning prefix for flow messages

    @Timer
    Timer committed Apr 23, 2017
    Configuration menu
    Copy the full SHA
    1df2cb5 View commit details
    Browse the repository at this point in the history

  9. Update README

    @Timer
    Timer committed Apr 23, 2017
    Configuration menu
    Copy the full SHA
    70ad8dd View commit details
    Browse the repository at this point in the history

  10. Don't double compute

    @Timer
    Timer committed Apr 23, 2017
    Configuration menu
    Copy the full SHA
    45841cd View commit details
    Browse the repository at this point in the history

  11. Fix linter errors

    @Timer
    Timer committed Apr 23, 2017
    Configuration menu
    Copy the full SHA
    dab6f9d View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2017

  1. Use default perm check

    @Timer
    Timer committed Apr 24, 2017
    Configuration menu
    Copy the full SHA
    1cb808e View commit details
    Browse the repository at this point in the history

  2. Handle already running server since it exits with a non-zero

    @Timer
    Timer committed Apr 24, 2017
    Configuration menu
    Copy the full SHA
    e94387c View commit details
    Browse the repository at this point in the history

  3. Reduce nesting

    @Timer
    Timer committed Apr 24, 2017
    Configuration menu
    Copy the full SHA
    45e6c29 View commit details
    Browse the repository at this point in the history

  4. Simulate a mutex for startFlow

    @Timer
    Timer committed Apr 24, 2017
    Configuration menu
    Copy the full SHA
    fb4735c View commit details
    Browse the repository at this point in the history

Commits on May 4, 2017

  1. Fix unhandled rejection

    @Timer
    Timer committed May 4, 2017
    Configuration menu
    Copy the full SHA
    800af94 View commit details
    Browse the repository at this point in the history

  2. Upgrade flow

    @Timer
    Timer committed May 4, 2017
    Configuration menu
    Copy the full SHA
    ad625f1 View commit details
    Browse the repository at this point in the history