Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bootstrap with Yarn #2673

Merged
merged 6 commits into from
Jun 29, 2017
Merged

Bootstrap with Yarn #2673

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3917b55
Bootstrap with Yarn if we can
Timer Jun 28, 2017
bd13800
Update test scripts
Timer Jun 28, 2017
a69ede5
Check OS and npm concurrency ability
Timer Jun 28, 2017
5265339
Windows support
Timer Jun 28, 2017
e876b7d
Update bootstrap.js
Timer Jun 28, 2017
4b6dde7
Install yarn before bootstrap
Timer Jun 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Windows support
  • Loading branch information
@Timer
Timer committed Jun 28, 2017
commit 5265339286b661dbbbaee8e40da52ea0a14b6b5d
11 changes: 9 additions & 2 deletions bootstrap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,14 @@ function shouldUseNpmConcurrently() {
}

const yarn = shouldUseYarn();
const lerna = resolve(__dirname, 'node_modules', '.bin', 'lerna');
const windows = platform() === 'win32';
const lerna = resolve(
__dirname,
'node_modules',
'.bin',
windows ? 'lerna.cmd' : 'lerna'
);

if (!existsSync(lerna)) {
if (yarn) {
console.log('Cannot find lerna. Please run `yarn --check-files`.');
Expand All @@ -48,7 +55,7 @@ if (yarn) {
let args = ['bootstrap'];
if (
// The Window's filesystem does not handle concurrency well
platform() === 'win32' ||
windows ||
// Only certain npm versions support concurrency
!shouldUseNpmConcurrently()
) {
Expand Down