Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force rebuild after npm install #349

Merged
merged 1 commit into from
Aug 3, 2016
Merged

Force rebuild after npm install #349

merged 1 commit into from
Aug 3, 2016

Conversation

gaearon
Copy link
Contributor

@gaearon gaearon commented Aug 3, 2016

Fixes #186

@ghost ghost added the CLA Signed label Aug 3, 2016
var nodeModulesPath = this.nodeModulesPath;

// If any missing files are expected to appear in node_modules...
if (missingDeps.some(file => file.indexOf(nodeModulesPath) !== -1)) {
Copy link
Contributor

@vjeux vjeux Aug 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the minimum node version we support have arrow functions support?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@gaearon gaearon merged commit a7f9016 into master Aug 3, 2016
@gaearon gaearon added this to the 0.3.0 milestone Aug 3, 2016
@gaearon gaearon deleted the missing-deps branch August 3, 2016 22:51
compilation.contextDependencies.push(nodeModulesPath);
}

callback();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Express middleware calls this next, which I think is more explicit than callback

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most webpack plugins I saw use callback here but I don’t care either way, feel free to change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just trying to give more context, I don't particularly care :)

gaearon added a commit that referenced this pull request Aug 22, 2016
@gaearon gaearon modified the milestones: 0.2.2, 0.3.0 Aug 22, 2016
@gaearon gaearon mentioned this pull request Aug 22, 2016
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants