100% lighthouse score for progressive web app #7482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dscanlan
requested review from
bugzpodder,
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
mrmckeb
approved these changes
Aug 6, 2019
|
I'll see if we can get a second opinion here, but this looks great. Thanks @dscanlan! |
ianschmitz
approved these changes
Aug 7, 2019
|
Doesn't this robots.txt disable Google image search? If it does maybe there has to be documentation on how to make sure your images are (not) indexed. |
|
@JLarky That's a good point. Maybe we should remove |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation for PR #5926
Testing a newly created PWA app currently scores low on the lighthouse test from google. With CRA doing a great job of scaffolding, these changes makes creating a PWA straight out of the box more straight forward.
Things to do for template and template-typescript:
<meta name="description" content="Web site created using create-react-app"><link rel="apple-touch-icon" href="logo192.png">Comments Resolved:
<main>PWA Lighthouse reports
App created without these changes
App created with lighthouse changes