Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move unused eslint webpack import into @remove-on-eject block #7856

Merged

Conversation

mrseanbaines
Copy link
Contributor

It seems that when creating a new app with create-react-app, there is an unnecessary/unused eslint import in the generated webpack config which can be seen if you eject the project. I have now moved this import into the @remove-on-eject block.

Verified as working by locally running yarn create-react-app, ejecting and viewing the new project's webpack config, where the extra import is now gone.

@andriijas andriijas added this to the 3.2.1 milestone Oct 21, 2019
@andriijas andriijas merged commit f337acc into facebook:master Oct 21, 2019
@andriijas
Copy link
Contributor

Nice catch! Thanks for taking your time to submit the PR. Verified by bootstrapping new app and ejecting.

@mrseanbaines mrseanbaines deleted the unused-webpack-eslint-import branch October 21, 2019 07:53
@ghost ghost mentioned this pull request Oct 22, 2019
@iansu iansu modified the milestones: 3.2.1, 3.3 Oct 23, 2019
@lock lock bot locked and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants