Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix default value for docRootComponent #10337

Conversation

ultimate
Copy link
Contributor

@ultimate ultimate commented Jul 24, 2024

Hi,

this is my first PR for docusaurus - although just some documentation fix, please let me know if something is missing.

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Fix #10336

Test Plan

I ran docusaurus start and checked the changes in the documentation visually.

image

Deploy preview: https://deploy-preview-10337--docusaurus-2.netlify.app/docs/api/plugins/@docusaurus/plugin-content-docs#docRootComponent

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 24, 2024
Copy link

netlify bot commented Jul 24, 2024

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit cc93ebc
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/66a0ed8c7bfc2c00080363dc
😎 Deploy Preview https://deploy-preview-10337--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO Report
/ 🟠 82 🟢 98 🟢 96 🟢 100 Report
/docs/installation 🟠 55 🟢 97 🟢 100 🟢 100 Report
/docs/category/getting-started 🟠 75 🟢 100 🟢 100 🟠 86 Report
/blog 🟠 69 🟢 96 🟢 100 🟠 86 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 53 🟢 92 🟢 100 🟢 100 Report
/blog/tags/release 🟠 70 🟢 96 🟢 100 🟠 86 Report
/blog/tags 🟠 75 🟢 100 🟢 100 🟠 86 Report

@OzakIOne OzakIOne changed the title docs: fix #10336 wrong default value for plugin-content-docs docRootComponent docs: fix default value for docRootComponent Jul 24, 2024
@OzakIOne OzakIOne added the pr: documentation This PR works on the website or other text documents in the repo. label Jul 24, 2024
@OzakIOne
Copy link
Collaborator

I've added the deploy preview and modified title and text of the PR, LGTM

@slorber
Copy link
Collaborator

slorber commented Jul 25, 2024

thanks 👍

@slorber slorber merged commit 5e9e1d0 into facebook:main Jul 25, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong default value for plugin-content-docs docRootComponent
4 participants