fix(core): always alias React/ReactDOM to site dependency so that importing MDX from anywhere works #10391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⚡️ Lighthouse report for the deploy preview of this PR
|
2 tasks
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Size Change: +1.62 kB (+0.01%) Total Size: 11.6 MB
ℹ️ View Unchanged
|
|
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
|
FWIW, webpack itself advertises against this kind of aliasing, because it couples the build output to the file location and moving the file would bust the cache, generate different hashes, etc. Doesn't seem like a big deal though. |
|
Note for history: Next.js is doing something quite similar here: https://github.com/vercel/next.js/pull/69142/files |
This was referenced Sep 4, 2024
This was referenced Sep 4, 2024
This was referenced Sep 4, 2024
This was referenced Sep 4, 2024
This was referenced Sep 4, 2024
This was referenced Sep 6, 2024
This was referenced Sep 7, 2024
This was referenced Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This implements the suggestion here: #9027 (comment)
Using aliases ensures that when importing MDX partials from anywhere, React will always resolve to the site version instead of the local version.
Maybe it will cause problems for some sites so I'm including a secret env variable to disable this behavior, just in case. If you use it, please let us know why.
Test Plan
Dogfood test:
Test links
https://deploy-preview-10391--docusaurus-2.netlify.app/tests/docs/tests/import-bad-package