Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SafeAreaView flow type error in YellowBox #21897

Closed
3 tasks done
jjenzz opened this issue Oct 22, 2018 · 7 comments
Closed
3 tasks done

SafeAreaView flow type error in YellowBox #21897

jjenzz opened this issue Oct 22, 2018 · 7 comments
Labels
Bug Flow Resolution: Locked This issue was locked by the bot.

Comments

@jjenzz
Copy link

jjenzz commented Oct 22, 2018

Environment

  React Native Environment Info:
    System:
      OS: macOS 10.14
      CPU: x64 Intel(R) Core(TM) i7-6567U CPU @ 3.30GHz
      Memory: 2.18 GB / 16.00 GB
      Shell: 3.2.57 - /bin/bash
    Binaries:
      Node: 10.3.0 - ~/.nvm/versions/node/v10.3.0/bin/node
      Yarn: 1.6.0 - ~/.yarn/bin/yarn
      npm: 6.1.0 - ~/.nvm/versions/node/v10.3.0/bin/npm
      Watchman: 4.9.0 - /usr/local/bin/watchman
    SDKs:
      iOS SDK:
        Platforms: iOS 12.0, macOS 10.14, tvOS 12.0, watchOS 5.0
    IDEs:
      Android Studio: 3.1 AI-173.4819257
      Xcode: 10.0/10A255 - /usr/bin/xcodebuild
    npmPackages:
      @storybook/react-native: ^3.4.11 => 3.4.11
      react: 16.5.0 => 16.5.0
      react-native: 0.57.2 => 0.57.2
    npmGlobalPackages:
      react-native-cli: 2.0.1
      react-native-git-upgrade: 0.2.7

Description

image

image

Reproducible Demo

  1. Initialise new react native project with flow

  2. yarn flow check

  3. The following errors appear:
    image

  4. Add those files to [untyped] config:

    [untyped]
    .*/node_modules/react-native/Libraries/Components/Navigation/NavigatorIOS.ios.js
    .*/node_modules/react-native/Libraries/Components/TextInput/InputAccessoryView.js
    .*/node_modules/react-native/Libraries/Components/View/ViewPropTypes.js
    
  5. yarn flow check again

  6. YellowBox errors appear

@react-native-bot
Copy link
Collaborator

It looks like you are using an older version of React Native. Please update to the latest release, v0.57 and verify if the issue still exists.

The ":rewind:Old Version" label will be removed automatically once you edit your original post with the results of running react-native info on a project using the latest release.

@jjenzz
Copy link
Author

jjenzz commented Oct 22, 2018

@react-native-bot env info says 0.57.2 🙈 😛

Please remove Old Version label.

@radko93
Copy link
Contributor

radko93 commented Oct 24, 2018

@jjenzz latest is 0.57.3. Maybe consider submitting a PR to fix this issues?

@jjenzz
Copy link
Author

jjenzz commented Oct 29, 2018

@radko93 blimey, seems I can’t keep up haha. I’ll re-test in 0.53.3. I actually raised this with the intention to fix myself but haven’t gotten around to it yet 🙈

@radko93
Copy link
Contributor

radko93 commented Oct 29, 2018

Latest is 0.57.4 now :)

hramos added a commit to hramos/react-native-bot that referenced this issue Dec 4, 2018
…act-native version

Specifically, see facebook/react-native#21897, where the bot would match on @storybook/react-native: ^3.4.11
@hramos hramos added the Flow label Dec 14, 2018
@nate-whil
Copy link

The issue still exists with the files specified by @jjenzz with "react-native": "0.57.8" when upgrading from "flow-bin": "0.81.0" to "flow-bin": "0.82.0"

@thymikee
Copy link
Contributor

Hey! We can't actually see the reported bug on latest RN 0.59 so we'll close this issue, as this was likely fixed in 0.58 or later.

@facebook facebook locked as resolved and limited conversation to collaborators Mar 19, 2020
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Mar 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Flow Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

6 participants