Temporarily disable Android instrumentation tests #13239
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
grabbou
pushed a commit
that referenced
this pull request
Apr 3, 2017
Summary: Android instrumentation tests keep failing due to `java.lang.RuntimeException: java.lang.RuntimeException: Timed out waiting for JS thread`. An [earlier job](https://circleci.com/gh/facebook/react-native/17064) based off commit [c31a65](c31a656) finished successfully, yet [this job](https://circleci.com/gh/facebook/react-native/17070), triggered by the very [next commit](e82c2fb), failed Android instrumentation tests even though that commit touches no Android code. You can see from the [Circle history](https://circleci.com/gh/facebook/react-native/tree/master) that this test has been consistently failing for the same time out reason. I am disabling Android instrumentation tests as they are not providing any useful signal a this point in time. Debug and fix instrumentation tests, and re-enable them. Closes #13239 Differential Revision: D4810775 Pulled By: hramos fbshipit-source-id: 8866f9208ec3b5ac5f0ed2f6c2cf58c5b5825830
thotegowda
pushed a commit
to thotegowda/react-native
that referenced
this pull request
May 7, 2017
Summary: Android instrumentation tests keep failing due to `java.lang.RuntimeException: java.lang.RuntimeException: Timed out waiting for JS thread`. An [earlier job](https://circleci.com/gh/facebook/react-native/17064) based off commit [c31a65](facebook@c31a656) finished successfully, yet [this job](https://circleci.com/gh/facebook/react-native/17070), triggered by the very [next commit](facebook@e82c2fb), failed Android instrumentation tests even though that commit touches no Android code. You can see from the [Circle history](https://circleci.com/gh/facebook/react-native/tree/master) that this test has been consistently failing for the same time out reason. I am disabling Android instrumentation tests as they are not providing any useful signal a this point in time. Debug and fix instrumentation tests, and re-enable them. Closes facebook#13239 Differential Revision: D4810775 Pulled By: hramos fbshipit-source-id: 8866f9208ec3b5ac5f0ed2f6c2cf58c5b5825830
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android instrumentation tests keep failing due to
java.lang.RuntimeException: java.lang.RuntimeException: Timed out waiting for JS thread.An earlier job based off commit c31a65 finished successfully, yet this job, triggered by the very next commit, failed Android instrumentation tests even though that commit touches no Android code.
You can see from the Circle history that this test has been consistently failing for the same time out reason.
I am disabling Android instrumentation tests as they are not providing any useful signal a this point in time.
Next Steps
Debug and fix instrumentation tests, and re-enable them.