Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[standards] Rewrite imports in RNTester to use standard paths #24317

Closed
wants to merge 2 commits into from
Closed

[standards] Rewrite imports in RNTester to use standard paths #24317

wants to merge 2 commits into from

Commits on Apr 10, 2019

  1. [standards] Rewrite imports in RNTester to use standard paths 

    See facebook#24316 for the motivation. This commit rewrites the imports in the RNTester project.

Test Plan: Run RNTester and verify that it loads without any issues. Tap through each screen to ensure the JS modules load (that is, were bundled) correctly.
    @ide @cpojer
    ide authored and cpojer committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    392fb66 View commit details
    Browse the repository at this point in the history

  2. Use react-native's public interface where possible 

    Instead of requiring specific files and bypassing the public interface, require react-native's exports where possible instead.
    @ide @cpojer
    ide authored and cpojer committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    d6917e4 View commit details
    Browse the repository at this point in the history