[TM] Add specs for ModalManager #24896
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
react-native-bot
added
Component: Modal
Type: Enhancement
|
|
||
| export interface Spec extends TurboModule { | ||
| // RCTEventEmitter | ||
| +addListener: (eventName: string, handler: Function) => Object; |
There was a problem hiding this comment.
remove these listeners, since it is not an event emitter
There was a problem hiding this comment.
RCTModalManager actually extends RCTEventEmitter
There was a problem hiding this comment.
What @fkgozali said I couldn't get flow to run otherwise.
| Platform.OS === 'ios' && NativeModules.ModalManager | ||
| ? new NativeEventEmitter(NativeModules.ModalManager) | ||
| : null; | ||
| Platform.OS === 'ios' ? require('./NativeModalManager').default : null; |
There was a problem hiding this comment.
change this to an import, also, do the condition in NativeModalManager.js not here.
There was a problem hiding this comment.
@fkgozali has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @abhiin1947 in a3479c2. When will my fix make it into a release? | Upcoming Releases |
Summary: Part of facebook#24875 ## Changelog [General] [Added] - Add TurboModule spec for ModalManager Pull Request resolved: facebook#24896 Reviewed By: rickhanlonii Differential Revision: D15471097 Pulled By: fkgozali fbshipit-source-id: 99671583ddc2a6fc32fd1bcf9a6e340ad93a27c2
Summary
Part of #24875
Changelog
[General] [Added] - Add TurboModule spec for ModalManager
Test Plan
Flow and tests pass